Skip to content

✨ Custom filter placeholder text for data table #2261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 13, 2022
Merged

✨ Custom filter placeholder text for data table #2261

merged 5 commits into from
Oct 13, 2022

Conversation

@fraghag
Copy link

@fraghag fraghag commented Oct 6, 2022 •
edited
Loading

This has been asked for by multiple people in the community:
https://community.plotly.com/t/custom-text-in-datatable-filter-cell/34950/1

Contributor Checklist

  • I have broken down my PR scope into the following TODO tasks
    • Add setting for custom data table column filter placeholder text
    • Update the docs
  • I have run the tests locally and they passed. (refer to testing section in contributing)
  • I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

optionals

  • I have added entry in the CHANGELOG.md
  • If this PR needs a follow-up in dash docs, community thread, I have mentioned the relevant URLS as follows
    • this GitHub #PR number updates the dash docs
    • here is the show and tell thread in Plotly Dash community

@fraghag fraghag requested a review from alexcjohnson as a code owner October 6, 2022 15:36
alexcjohnson
alexcjohnson reviewed Oct 6, 2022
View reviewed changes
@alexcjohnson
Copy link
Collaborator

alexcjohnson commented Oct 6, 2022

Thanks @fraghag - very nicely done. Aside from my two minor comments above, just a changelog entry and I think we'll be good to go!

@fraghag
Copy link
Author

fraghag commented Oct 7, 2022

Thanks @fraghag - very nicely done. Aside from my two minor comments above, just a changelog entry and I think we'll be good to go!

Fixed the comments now. But regarding the changelog, I don't understand where in the Changelog file I'm supposed to add this, I only see entries from already released versions. I was looking form info about this in the CONTRIBUTING file. Could you give me some pointers?

alexcjohnson
alexcjohnson reviewed Oct 7, 2022
View reviewed changes
@alexcjohnson
Copy link
Collaborator

alexcjohnson commented Oct 7, 2022

Re: changelog - yeah we should describe that better, good point. You can add a new section at the top, right before the [2.6.2] heading:

## Unreleased

### Added

- [#2261](https://github.com/plotly/dash/pull/2261) 1-2 sentence description of the feature

alexcjohnson
alexcjohnson approved these changes Oct 13, 2022
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Excellent work, thanks again for the PR @fraghag!

@alexcjohnson alexcjohnson merged commit 865c93b into plotly:dev Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fraghag @alexcjohnson